Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom cloze tokens #607

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

polyipseity
Copy link
Contributor

@polyipseity polyipseity commented Jan 22, 2023

I have decided to implement custom cloze tokens (closes #556) myself.

For now, I have simply added two text field settings defaulted to empty. Empty means not using any custom cloze tokens. The existing three cloze settings are kept.

Edit: also closes #387

Signed-off-by: William So <polyipseity@gmail.com>
@polyipseity
Copy link
Contributor Author

polyipseity commented Jan 22, 2023 via email

Signed-off-by: William So <polyipseity@gmail.com>
Signed-off-by: William So <polyipseity@gmail.com>
Signed-off-by: William So <polyipseity@gmail.com>
@Newdea
Copy link
Contributor

Newdea commented Aug 21, 2023

it seems pretty good, @st3v3nmw hope the master branch will merge it soon.

Copy link
Owner

@st3v3nmw st3v3nmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the contribution 😄!

Sorry the underlying code has gone through a major refactor recently. I'm not sure if you're still available to help resolve the merge conflicts.

Stephen,

Signed-off-by: William So <polyipseity@gmail.com>

# Conflicts:
#	src/main.ts
#	src/parser.ts
#	tests/unit/parser.test.ts
Signed-off-by: William So <polyipseity@gmail.com>
Signed-off-by: William So <polyipseity@gmail.com>
Signed-off-by: William So <polyipseity@gmail.com>
Signed-off-by: William So <polyipseity@gmail.com>
@polyipseity
Copy link
Contributor Author

Done, not too hard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Custom cloze tokens [FEAT] Adding support for strikethrough/custom cloze
3 participants