Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI changes needed for BBS+ #334

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

CLI changes needed for BBS+ #334

wants to merge 9 commits into from

Conversation

thefireskater
Copy link
Collaborator

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jan 30, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

sbihel
sbihel approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@sbihel sbihel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, sorry for the messiness of the CLI, we need to refactor it.

I'll review the ssi PR another day

cli/src/main.rs
@@ -29,6 +29,9 @@ use didkit_cli::opts::ResolverOptions;

#[derive(StructOpt, Debug)]
pub enum DIDKit {
#[clap(setting(clap::AppSettings::Hidden))]
GenerateBls12381Key,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put it in KeyGenerateCmd ? Then the command will be didkit key generate bls12381

cli/src/main.rs
@@ -999,6 +1051,7 @@ fn main() -> AResult<()> {
false,
Some(&options),
&mut loader,
false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can rebase on main

sbihel
sbihel requested changes Jan 31, 2023
View reviewed changes
Copy link
Member

@sbihel sbihel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just blocking to avoid any premature merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbihel sbihel sbihel requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thefireskater @CLAassistant @sbihel