code cleanup: remove glooctl v2 references #9435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
keep pr updated
jenshu
removed
the
keep pr updated
|
Issues linked to changelog: |
jenshu
changed the title
|
Visit the preview URL for this PR (updated for commit 5de3141): https://gloo-edge--pr9435-gg-naming-cleanup-nm7r88ps.web.app (expires Fri, 07 Jun 2024 17:03:08 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
npolshakova
approved these changes
May 31, 2024
davidjumani
reviewed
May 31, 2024
There was a problem hiding this comment.
Does this also need to be changed ?
gloo/projects/gloo/cli/install.ps1
Line 23 in f8ea746
looks like that was added earlier and not related to GG v2 #8856 |
davidjumani
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove v2 references from glooctl code (rename to kubegateway).
This should have no user-facing changes. The kubegateway glooctl integration is not currently functional.