Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested changes for Hierarchical EM implementation #1411

Open
wants to merge 29 commits into
base: EMsimulationFaceProperties
Choose a base branch
from

Conversation

jcapriot
Copy link
Member

@jcapriot jcapriot commented Apr 8, 2024

Summary

Implements my suggestions in #1296.

PR Checklist

  • If this is a work in progress PR, set as a Draft PR
  • Linted my code according to the style guides.
  • Added tests to verify changes to the code.
  • Added necessary documentation to any new functions/classes following the
    expect style.
  • Marked as ready for review (if this is was a draft PR), and converted
    to a Pull Request
  • Tagged @simpeg/simpeg-developers when ready for review.

What does this implement/fix?

  • Rename to Hierarchical simulations
  • Simplifies code for the hierarchical simulations (and fields) by making use of inheritance.

Additional information

Also adapted some relevant tests to pytest parameterized formats.

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 39.28571% with 51 lines in your changes are missing coverage. Please review.

Project coverage is 68.56%. Comparing base (b85f758) to head (afe5e63).
Report is 50 commits behind head on EMsimulationFaceProperties.

❗ Current head afe5e63 differs from pull request most recent head 39244bc. Consider uploading reports for the commit 39244bc to get more accurate results

Files Patch % Lines
SimPEG/base/pde_simulation.py 27.86% 44 Missing ⚠️
SimPEG/electromagnetics/frequency_domain/fields.py 50.00% 4 Missing ⚠️
SimPEG/electromagnetics/utils/testing_utils.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                       @@
##           EMsimulationFaceProperties    #1411       +/-   ##
===============================================================
- Coverage                       82.54%   68.56%   -13.99%     
===============================================================
  Files                             167      167               
  Lines                           25700    26095      +395     
===============================================================
- Hits                            21214    17891     -3323     
- Misses                           4486     8204     +3718     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant