-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggested changes for Hierarchical EM implementation #1411
base: EMsimulationFaceProperties
Are you sure you want to change the base?
Suggested changes for Hierarchical EM implementation #1411
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## EMsimulationFaceProperties #1411 +/- ##
===============================================================
- Coverage 82.54% 68.56% -13.99%
===============================================================
Files 167 167
Lines 25700 26095 +395
===============================================================
- Hits 21214 17891 -3323
- Misses 4486 8204 +3718 ☔ View full report in Codecov by Sentry. |
Summary
Implements my suggestions in #1296.
PR Checklist
expect style.
to a Pull Request
@simpeg/simpeg-developers
when ready for review.What does this implement/fix?
Additional information
Also adapted some relevant tests to pytest parameterized formats.