-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Irls refactor #1349
base: main
Are you sure you want to change the base?
Irls refactor #1349
Conversation
Sorry for the messy commit history. Pycharm went a bit nuts on the imports. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1349 +/- ##
===========================================
+ Coverage 66.89% 82.67% +15.78%
===========================================
Files 169 170 +1
Lines 25747 25805 +58
===========================================
+ Hits 17223 21335 +4112
+ Misses 8524 4470 -4054 ☔ View full report in Codecov by Sentry. |
No worries! We can Squash and Merge and clean it up later. I see a few tests failing. Do you want me to review it now @domfournier? Or are you still working on it? |
Hi @santisoler , yes let me fix those. I can ping you when I am done with it. Errors are mostly related to examples using deprecated arguments, which I should handle more gracefully right here. Are we ok with updating the tests/examples for suppress the warnings after, on a separate PR? |
Sounds good!
It would be ok to update the examples here as well. But we can totally handle them in a separate PR if you feel we need to change a lot of them. |
# Conflicts: # SimPEG/directives/directives.py
# Conflicts: # SimPEG/directives/__init__.py # simpeg/directives/_regularization.py
… irls_refactor
ready for review @simpeg/simpeg-developers |
Summary
Refactoring of the UpdateIRLS directive used to control the
Sparse
regularization.SphericalDomain
directive.BetaSchedule
directive.PR Checklist
expect style.
to a Pull Request
@simpeg/simpeg-developers
when ready for review.Reference issue
Related to restructuring proposed on #1327
What does this implement/fix?
Reduces complexity of current
Update_IRLS
class + PEP8 standard.Additional information
Clean up deprecation warnings on #1472