This repository has been archived by the owner on Sep 7, 2023. It is now read-only.
Add a new engine: Baidu #3182
Open
Add a new engine: Baidu #3182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
reviewed
Mar 17, 2022
| @@ -398,7 +398,11 @@ engines: | |||
| timeout : 3.0 | |||
| weight : 2 | |||
| tests: *tests_infobox | |||
|
|
|||
| - name: baidu | |||
There was a problem hiding this comment.
Suggested change
| - name: baidu | |
| - name: baidu |
kvch
reviewed
Mar 17, 2022
| engine : baidu | ||
| shortcut : bd | ||
| timeout : 2.0 | ||
| disabled : True |
There was a problem hiding this comment.
Suggested change
| disabled : True | |
| disabled : True | |
kvch
reviewed
Mar 17, 2022
| @@ -1,5 +1,6 @@ | |||
| certifi==2021.10.8 | |||
| babel==2.9.1 | |||
| beautifulsoup4==4.10.0 | |||
There was a problem hiding this comment.
I would rahter not add a new dependency. Is there any reason why you used this lib instead of lxml like in other engines?
Example:
from lxml import html
dom = html.fromstring(resp.text)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a new search engine https://www.baidu.com/
Why is this change important?
Baidu is a chinese search engine which is famous in China, so I think it is necessary to add it.
How to test this PR locally?
Run
sudo make runGo to
/preferencesDisable all search engines with the exception of onesearch (the last one)
Make some search
Assert that it works as expected
Assert that the pagination works
Author's checklist
This search engine is OFF by default.
HTML parser from python-baidusearch
Related issues
#1622