Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install typing stubs for boto3 and botocore. #6370

Merged
merged 1 commit into from
May 28, 2024

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented May 18, 2024

Also installs pytest and switches attrs and Pillow from separate stubs to built-in ones following the separate stub package descriptions.

Copy link

codecov bot commented May 18, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 89.80%. Comparing base (180bc9b) to head (4b16685).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6370      +/-   ##
==========================================
+ Coverage   85.00%   89.80%   +4.80%     
==========================================
  Files         161      162       +1     
  Lines       11962    12113     +151     
  Branches     1872     1901      +29     
==========================================
+ Hits        10168    10878     +710     
+ Misses       1512      927     -585     
- Partials      282      308      +26     
Files Coverage Δ
scrapy/core/downloader/handlers/s3.py 94.54% <100.00%> (+65.45%) ⬆️
scrapy/extensions/feedexport.py 93.13% <60.00%> (+9.38%) ⬆️

... and 20 files with indirect coverage changes

@Gallaecio Gallaecio merged commit 9ba4dd3 into scrapy:master May 28, 2024
26 of 27 checks passed
@wRAR wRAR deleted the more-typing-deps branch June 6, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants