Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow query checkout for all users. #16011

Merged
merged 2 commits into from
May 21, 2024
Merged

Allow query checkout for all users. #16011

merged 2 commits into from
May 21, 2024

Conversation

Air-t
Copy link
Member

@Air-t Air-t commented May 17, 2024

Port: #16001

Impact

  • New migrations
  • New/Updated API fields or mutations
  • Deprecated API fields or mutations
  • Removed API types, fields, or mutations

Docs

  • Link to documentation:

Pull Request Checklist

  • Privileged queries and mutations are either absent or guarded by proper permission checks
  • Database queries are optimized and the number of queries is constant
  • Database migrations are either absent or optimized for zero downtime
  • The changes are covered by test cases
  • All new fields/inputs/mutations have proper labels added (ADDED_IN_X, PREVIEW_FEATURE, etc.)
  • All migrations have proper dependencies
  • All indexes are added concurrently in migrations
  • All RunSql and RunPython migrations have revert option defined

* Add PermissionDenied error for inactive channel for checkout query
  instead of None
* Add additional permision HANDLE_PAYMENTS to query checkouts
@Air-t Air-t added checkout 3.17 shopping Shopping Experience team topics labels May 17, 2024
@Air-t Air-t self-assigned this May 17, 2024
@db-queries
Copy link

db-queries bot commented May 17, 2024

Here is the report for 7d1cf27 (saleor:3.17-fix-checkout-permissions)
Missing base report (22594ee). The results couldn't be compared.

No differences were found.

@Air-t Air-t requested a review from a team May 17, 2024 08:55
@IKarbowiak IKarbowiak requested a review from a team May 17, 2024 12:07
@Air-t Air-t requested a review from a team May 21, 2024 07:14
@korycins korycins requested a review from a team May 21, 2024 07:49
@Air-t Air-t merged commit 96f736c into 3.17 May 21, 2024
5 checks passed
@Air-t Air-t deleted the 3.17-fix-checkout-permissions branch May 21, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.17 checkout shopping Shopping Experience team topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants