Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to LLVM 18.1.6 #125288

Merged
merged 1 commit into from
May 20, 2024
Merged

Update to LLVM 18.1.6 #125288

merged 1 commit into from
May 20, 2024
+2 −2

Conversation

nikic
Copy link
Contributor

@nikic nikic commented May 19, 2024 •
edited

This rebases our LLVM fork on top of LLVM 18.1.6, which is planned to be the last release of the 18.x series.

Fixes #123695 (miscompile with wrapping pointer arithmetic).
Fixes #125053 (compiler crash on M1).
Also fixes https://bugzilla.redhat.com/show_bug.cgi?id=2226905 (crypto miscompile on s390x).

r? @cuviper

@rustbot
Copy link
Collaborator

rustbot commented May 19, 2024

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 19, 2024
@cuviper
Copy link
Member

cuviper commented May 20, 2024

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented May 20, 2024

📌 Commit e57f9ac has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2024
@bors
Copy link
Contributor

bors commented May 20, 2024

⌛ Testing commit e57f9ac with merge 20483b6...

@bors
Copy link
Contributor

bors commented May 20, 2024

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 20483b6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 20, 2024
@bors bors merged commit 20483b6 into rust-lang:master May 20, 2024
7 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 20, 2024
@nikic nikic added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 20, 2024
@nikic
Copy link
Contributor Author

nikic commented May 20, 2024

Nominating for backport, as this fixes multiple miscompilations known to affect Rust code.

@DianQK
Copy link
Member

DianQK commented May 20, 2024

Maybe we can cherry-pick some commits to rustc/18.0-2024-02-13?

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (20483b6): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.4% [-0.5%, -0.2%] 4
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.5% [3.5%, 3.5%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.3% [-2.6%, -2.0%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.4% [-2.6%, 3.5%] 3

Cycles

Results (secondary -4.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.0% [-6.3%, -1.1%] 6
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 670.375s -> 670.193s (-0.03%)
Artifact size: 316.15 MiB -> 316.05 MiB (-0.03%)

@jwong101 jwong101 mentioned this pull request May 21, 2024
Open
@DianQK
Copy link
Member

DianQK commented May 23, 2024

This is just a summary of the changes made in this update. The aim is to quickly understand what changes have been made. I am not able to review these changes for potential issues here. We should trust that these changes have undergone two rounds of reviews by upstream experts (merging into the main branch and backporting to release/18.x).

From my personal perspective, this update fixes many issues on the T1 and T2 platforms, and I believe we should backport this PR.

The only thing to note is that there is a regression issue with PowerPC (T2), see: llvm/llvm-project#92991, but this should be fixed and updated soon.

The relevant changes are as follows, which I generated using the script git --no-pager log --pretty=format:"%s [%h](https://github.com/llvm/llvm-project/commit/%h)" 1deeee3f5da4f323e0e5b33688450dc066e9651b...llvmorg-18.1.6 --stat -- llvm/lib | sed -e 's/ (#[0-9]*)//g' -e 's/^[[:space:]]*//;s/[[:space:]]*$//'':
(I removed the changes related to AMDGPU.)

Details

@apiraino
Copy link
Contributor

Beta backport approved as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle.

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label May 24, 2024
@cuviper cuviper mentioned this pull request May 25, 2024
Merged
@cuviper cuviper modified the milestones: 1.80.0, 1.79.0 May 25, 2024
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 25, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request May 25, 2024
@bors
Auto merge of rust-lang#125529 - cuviper:beta-next, r=cuviper
2423248 
[beta] backports

- Add `#[inline]` to float `Debug` fallback used by `cfg(no_fp_fmt_parse)` rust-lang#125252
- Add v0 symbol mangling for `f16` and `f128` rust-lang#123816
- Only make GAT ambiguous in `match_projection_projections` considering shallow resolvability rust-lang#125214
- Update to LLVM 18.1.6 rust-lang#125288

r? cuviper
bors added a commit to rust-lang-ci/rust that referenced this pull request May 25, 2024
@bors
Auto merge of rust-lang#125529 - cuviper:beta-next, r=cuviper
d9e85b5 
[beta] backports

- Add `#[inline]` to float `Debug` fallback used by `cfg(no_fp_fmt_parse)` rust-lang#125252
- Add v0 symbol mangling for `f16` and `f128` rust-lang#123816
- Only make GAT ambiguous in `match_projection_projections` considering shallow resolvability rust-lang#125214
- Update to LLVM 18.1.6 rust-lang#125288

r? cuviper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
7 participants
@nikic @rustbot @cuviper @bors @DianQK @rust-timer @apiraino