-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Bedrock Titan Embeddings v2 #13580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @brycecf!
...ntegrations/embeddings/llama-index-embeddings-bedrock/llama_index/embeddings/bedrock/base.py
Outdated
Show resolved
Hide resolved
...ntegrations/embeddings/llama-index-embeddings-bedrock/llama_index/embeddings/bedrock/base.py
Show resolved
Hide resolved
...ntegrations/embeddings/llama-index-embeddings-bedrock/llama_index/embeddings/bedrock/base.py
Outdated
Show resolved
Hide resolved
* Added checks for Titan v2 params with exceptions thrown if used in v1. * Changed constructor params from `model` to `model_name` to match BaseEmbedding.
…2 tests to use `additional_kwargs`.
Hello @logan-markewich and @nerdai, any idea on when this will get merged I was waiting for this feature for my project instead of monkey patching. |
...ntegrations/embeddings/llama-index-embeddings-bedrock/llama_index/embeddings/bedrock/base.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! thanks @brycecf -- this will get merged once our actions pass
Description
dimensions
andnormalize
, so added new field,titan_body_kwargs
, to support.model
field tomodel_name
to adhere to that used in parent class,BaseEmbedding
. Bumped to0.2.0
consequently.Version Bump?
Did I bump the version in the
pyproject.toml
file of the package I am updating? (Except for thellama-index-core
package)Type of Change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lint
to appease the lint gods