[core] Replace CINT with CLING #15513
Conversation
in preprocessor statements. Fixes root-project#10058
dpiparo
requested review from
bellenot,
linev,
osschar,
couet,
jblomer,
pcanal,
lmoneta,
gganis,
agheata and
vepadulano
as code owners
|
Thank you for the initiative! You're also replacing Maybe @pcanal can confirm, but from that paragraph I understand that the replacement for |
Test Results 10 files 10 suites 1d 18h 30m 11s ⏱️ For more details on these failures, see this check. Results for commit ede7404. |
| if (strstr(cs, "#ifndef__CINT__") || | ||
| strstr(cs, "#if!defined(__CINT__)")) |
There was a problem hiding this comment.
Do we want to check here for both, __CINT__ and __CLING__?
| @@ -9,7 +9,7 @@ | |||
| * For the list of contributors see $ROOTSYS/README/CREDITS. * | |||
| *************************************************************************/ | |||
|
|
|||
| #ifdef __CINT__ | |||
| #ifdef __CLING__ | |||
There was a problem hiding this comment.
A more semantically accurate replacement within a LinkDef file is:
| #ifdef __CLING__ | |
| #ifdef __ROOTCLING__ |
(i.e. needed only during dictionary generation and not during interpretation)
| @@ -926,7 +926,7 @@ class MakeHilbert : public TElementPosActionD { | |||
| MakeHilbert() { } | |||
| }; | |||
|
|
|||
| #if !defined (__CINT__) || defined (__MAKECINT__) | |||
| #if !defined (__CLING__) || defined (__MAKECLING__) | |||
There was a problem hiding this comment.
| #if !defined (__CLING__) || defined (__MAKECLING__) | |
| #if !defined (__CLING__) || defined (__ROOTCLING__) |
| @@ -16,7 +16,7 @@ | |||
| /// code, this script must also be compiled to work correctly. | |||
| /// | |||
| /// ~~~{.cpp} | |||
| /// #if defined(__CINT__) && !defined(__MAKECINT__) | |||
| /// #if defined(__CLING__) && !defined(__MAKECLING__) | |||
There was a problem hiding this comment.
| /// #if defined(__CLING__) && !defined(__MAKECLING__) | |
| /// #if defined(__CLING__) && !defined(__ROOTCLING__) |
| @@ -101,7 +101,7 @@ void read() { | |||
|
|
|||
| void runIt() { | |||
|
|
|||
| #if defined(__CINT__) && !defined(__MAKECINT__) | |||
| #if defined(__CLING__) && !defined(__MAKECLING__) | |||
There was a problem hiding this comment.
| #if defined(__CLING__) && !defined(__MAKECLING__) | |
| #if defined(__CLING__) && !defined(__ROOTCLING__) |
| @@ -116,7 +116,7 @@ void runIt() { | |||
| } | |||
|
|
|||
| void mathcoreVectorFloatIO() { | |||
| #if defined(__CINT__) && !defined(__MAKECINT__) | |||
| #if defined(__CLING__) && !defined(__MAKECLING__) | |||
There was a problem hiding this comment.
| #if defined(__CLING__) && !defined(__MAKECLING__) | |
| #if defined(__CLING__) && !defined(__ROOTCLING__) |
in preprocessor statements.
Fixes #10058