[TMVA] Add missing TMVA python dependencies to requirements.txt #15512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14553.
This PR adds the dependencies for the TMVA GNN unit tests to the
docker images via the
requirements.txt
. However, this will only have adelayed effect until the images are re-built. Therefore, we can't
validate for now that the tests actually work.
Once the missing packages make it into the CI images, a PR should be
opened to revert this commit.
For the JsMVA dependency, we don't have to worry about anything.
The JsMVA tests have already been temporarily disabled by @dpiparo 7 years ago:
https://github.com/root-project/roottest/blame/master/python/JsMVA/CMakeLists.txt
Note: adding the new dependencies only grows the environment by 20 MB, which is less then 1 % of a size increase (the size of the environment is currently 2.3 GB).