Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CINT still around #10058

Open
ferdymercury opened this issue Mar 5, 2022 · 1 comment · May be fixed by #15513
Open

CINT still around #10058

ferdymercury opened this issue Mar 5, 2022 · 1 comment · May be fixed by #15513
Assignees
@dpiparo
Labels
fixathon This issue can be tackled at a ROOT fixathon improvement in:Build System in:Cling

Comments

@ferdymercury
Copy link
Collaborator

Explain what you would like to see improved

grep on the source code still shows many places where CINT is mentioned.

Optional: share how it could be improved

Change to equivalent variables in Cling, or remove if no longer needed.

For example:

__CINT__ --> __CLING__

To Reproduce

grep -r CINT root-src

Setup

   ------------------------------------------------------------------
  | Welcome to ROOT 6.27/01                        https://root.cern |
  | (c) 1995-2021, The ROOT Team; conception: R. Brun, F. Rademakers |
  | Built for linuxx8664gcc on Jan 12 2022, 10:17:19                 |
  | From heads/master@v6-25-01-2870-gdac9b6398d                      |
  | With c++ (Ubuntu 8.4.0-1ubuntu1~18.04) 8.4.0                     |
  | Try '.help', '.demo', '.license', '.credits', '.quit'/'.q'       |
   ------------------------------------------------------------------
guitargeek added a commit to guitargeek/root that referenced this issue Nov 15, 2023
@guitargeek
[TMVA] Remove workaround from the CINT era
972da8b 
Since cling can deal with `dynamic_cast` correctly, the
`TMVA::Reader::FindCutsMVA()` workaround is not needed anymore.

That's one of the changes necessary to address root-project#10058.
@guitargeek guitargeek mentioned this issue Nov 15, 2023
Merged
guitargeek added a commit that referenced this issue Nov 15, 2023
@guitargeek
[TMVA] Remove workaround from the CINT era
dacbb2a 
Since cling can deal with `dynamic_cast` correctly, the
`TMVA::Reader::FindCutsMVA()` workaround is not needed anymore.

That's one of the changes necessary to address #10058.
maksgraczyk pushed a commit to maksgraczyk/root that referenced this issue Jan 12, 2024
@guitargeek @maksgraczyk
[TMVA] Remove workaround from the CINT era
7bd90b4 
Since cling can deal with `dynamic_cast` correctly, the
`TMVA::Reader::FindCutsMVA()` workaround is not needed anymore.

That's one of the changes necessary to address root-project#10058.
@dpiparo dpiparo assigned dpiparo and unassigned Axel-Naumann Feb 4, 2024
@vepadulano vepadulano added the fixathon This issue can be tackled at a ROOT fixathon label Feb 5, 2024
@ferdymercury
Copy link
Collaborator Author

@vgvassilev just addressed part of this issue with a couple of commits

dpiparo added a commit to dpiparo/root that referenced this issue May 14, 2024
@dpiparo
[core] Replace CINT with CLING
ede7404 
in preprocessor statements.

Fixes root-project#10058
@dpiparo dpiparo linked a pull request May 14, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dpiparo dpiparo

Labels
fixathon This issue can be tackled at a ROOT fixathon improvement in:Build System in:Cling
Projects
Fixathon
Status: PR is open
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[core] Replace CINT with CLING dpiparo/root
4 participants
@Axel-Naumann @dpiparo @ferdymercury @vepadulano