feat(node-resolve): allow preferBuiltins to be a function #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellscape
reviewed
Jun 5, 2024
| @@ -30,13 +30,12 @@ test('handles importing builtins', async (t) => { | |||
| }); | |||
|
|
|||
| test('warning when preferring a builtin module, no explicit configuration', async (t) => { | |||
| let warning = null; | |||
There was a problem hiding this comment.
we always prefer adding another test instead of modifying an existing test. What was the reason that this test was modified?
There was a problem hiding this comment.
Because I added new warning message after the original here.
So this test is modified to let the warnings match exactly.
younggglcy
force-pushed
the
feat/node_resolve_prefer_bulitins
branch
from
9eaa425
to
7e12e8c
Compare
younggglcy
force-pushed
the
feat/node_resolve_prefer_bulitins
branch
from
7e12e8c
to
9eaa425
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
@rollup/plugin-node-resolveThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers: resolves #1655
Description
I think #1665 proposes a nice feature that gives
preferBuiltinsa more fine-grained control, so I'm trying to resolve this a little inactive issue.This PR only makes
node-resolveaccept a function parameter topreferBuiltinsto introduce as little as possible without changing the existing API.#1665 also proposes that it should match the behavior of the
externalrollup configuration. But I think in most cases, we only need to mark some modules as non-builtins, e.g., deprecated modules likepunycode. And this is somehow contrary to the behavior of theexternal.Is accepting a function enough or should we add some extra configs? I'm willing to contribute if we need to make more changes.