Update Node.js versions in CI #1307
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we add a variable for jaribu vs. mocha tests, we could use a matrix strategy and exclude Node 18 and 20 for jaribu. |
|
Sounds good to me. Want to have a go at that? |
|
I have a couple things in my pipeline before then, but yes. |
|
Do we know what the cause of the failures is? Might be an easy fix in jaribu, even though I've deprecated it. |
|
The error message is "test failed ReferenceError: FileReader is not defined". IIRC, it has something to do with what APIs are available in which version of Node. |
|
@silverbucket See #1300 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.