-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: appropriately set prevRoute and nextRoute in getRouteMeta.tsx #6769
base: main
Are you sure you want to change the base?
Conversation
at the moment, on the blog, the link to the previous route is actually the next route and that of the next route, is the article before the current one (the open page). that default comes from this file and to fix it, i set `prevRoute` to `ctx.route` initially and when the current route is found, `prevRoute` is assigned the last breadcrumb if the current index is greater than 1.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @idorenyinudoh! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Five Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
at the moment, on the blog, the link to the previous route is actually the next route and that of the next route, is the article before the current one (the open page).
that default comes from this file and to fix it, i set
prevRoute
toctx.route
initially and when the current route is found,prevRoute
is assigned the last breadcrumb if the current index is greater than 1.for example, in this screenshot below, the next article was published in March 2023, while the previous was in February 2024. Meanwhile, it should be the other way round