dropbox: add option to override root namespace #7821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets you, for example, use shared folders without mounting them into your home namespace first, as long as you know their namespace ID. (The --dropbox-shared-folders flag could thus be changed to not need to mount the shared folder first, but I'm not doing that here as it's a behavior change, who knows, maybe somebody relies on it.)
wfraser
force-pushed
the
root-nsid-override
branch
from
f15ffe0
to
ad59c86
Compare
ncw
reviewed
May 13, 2024
There was a problem hiding this comment.
I think this change looks great thank you.
I'd just like to have a discussion about the naming.
In other backends we have called this feature like this
--box-root-folder-id string Fill in for rclone to use a non root folder as its starting point
--drive-root-folder-id string ID of the root folder
--filefabric-root-folder-id string ID of the root folder
--onedrive-root-folder-id string ID of the root folder
--pcloud-root-folder-id string Fill in for rclone to use a non root folder as its starting point (default "d0")
--pikpak-root-folder-id string ID of the root folder
--sharefile-root-folder-id string ID of the root folder
So I'm tempted to say we should do the same for the dropbox backend too and call this --dropbox-root-folder-id to fit in with the rest of rclone.
However dropbox have their very specific naming with namespaces so maybe it isn't a good idea. We could of course write lots of help explaining things.
What do you think?
I'll run the CI now too.
|
Thanks for the review! I think calling it "folder ID" here would be more confusing, because it needs to specifically be a namespace ID and not a file/folder ID (which is a different kind of identifier in the Dropbox API). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
This lets you, for example, use shared folders without mounting them into your home namespace first, as long as you know their namespace ID.
(The --dropbox-shared-folders flag could thus be changed to not need to mount the shared folder first, but I'm not doing that here as it's a behavior change, who knows, maybe somebody relies on it.)
This also allows access to your Dropbox Backups hidden namespace once you figure out what its namespace ID is.
Was the change discussed in an issue or in the forum before?
Checklist