cmd mountlib: adding remount option for linux systems - fixes #6488 #7802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Took a crack at addressing issue #6488 |
ncw
reviewed
May 10, 2024
cmd/mountlib/mount.go
Outdated
| @@ -161,6 +163,7 @@ func AddFlags(flagSet *pflag.FlagSet) { | |||
| flags.BoolVarP(flagSet, &Opt.NetworkMode, "network-mode", "", Opt.NetworkMode, "Mount as remote network drive, instead of fixed disk drive (supported on Windows only)", "Mount") | |||
| // Unix only | |||
| flags.DurationVarP(flagSet, &Opt.DaemonWait, "daemon-wait", "", Opt.DaemonWait, "Time to wait for ready mount from daemon (maximum time on Linux, constant sleep time on OSX/BSD) (not supported on Windows)", "Mount") | |||
| flagSet.BoolVarP(&Opt.Remount, "remount", "", false, "Remount a file system") | |||
There was a problem hiding this comment.
I suggest you wrap this in a if runtime.GOOS == "linux" { } then the flag will only appear for linux systems.
cmd/mountlib/mount.go
Outdated
| // Ensure sensible defaults | ||
| m.SetVolumeName(m.MountOpt.VolumeName) | ||
| m.SetDeviceName(m.MountOpt.DeviceName) | ||
|
|
||
| // Handle the --remount flag by attempting to unmount the mountpoint first | ||
| if m.MountOpt.Remount { |
There was a problem hiding this comment.
I'd probably put if runtime.GOOS == linux && m.MountOpt.Remount { here.
The compiler is smart enough to evaluate runtime.GOOS == linux at compile time then figure out it doesn't need to compile any of the stuff in the if statement so it saves bloating the binaries where this doesn't work.
|
ok made the updates, not sure about this Race test that is failing on the go1.20 build, let me know if I can do anything to fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
Added a --remount option as requested in issue #6488 . option only works on linux systems. Updated documentation to reflect this optional flag.
Was the change discussed in an issue or in the forum before?
Issue #6488
Checklist