Yandex Disk speed cap fixes #7659
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oauthutil: allows for a device-type authorization flow (used when no browser available)
Evengard
force-pushed
the
yandex-disk-speed-fixes
branch
from
5f0c2ae
to
3b73db7
Compare
|
@devnoname120 You might be interested |
|
Anyone?... @ncw ? |
|
@Evengard sorry for the delay reviewing. Do you think you could split this into two PRs? One for the speed improving user agent and one for the device-type authorization. They both look useful. The User Agent changes will be easy to merge, but I think the oauth stuff will require some thought (eg will with work with other backends, is it part of the standard, how can we stop it reading from stdin as part of the config flow etc). |
|
Man, I thought the policy "split your PRs" would be kept at the workplace 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
Now, this was an "exploratory PR", because I was initially having the wrong assumption about from where the speed cap actually comes from, hence why I implemented the device-type authorization flow first. I still kept it, as it should help people on systems without browsers to authenticate more easily...
It looks like the method how Yandex.Disk is actually limiting the speed is... The User-Agent. Yep, simple as that. When I sniffed the actual used UserAgent and tried to use it, miraculously, the speed limit was gone. So here we are, I just copied it from the official latest client, adjusted a bit and it Just Works ©. I still made sure that it is still possible to override it.
Was the change discussed in an issue or in the forum before?
This is a widely known problem. Found a thread here: https://forum.rclone.org/t/slow-upload-speed-yandex-disk/31943
Checklist