config: add options for OAuth functionality #7635
Conversation
For Docker environments, need to bind to 0.0.0.0 instead of localhost For rclone served by reverse proxy, should be able to override redirrect Fixes rclone#7634
|
Can you drop the formatting changes from docs.md please? It's very difficult see what you changed! Also why does this have a separate config for redirect URL? Will that be different to the bind address? Thank you for taking a look at this. |
|
Done, sorry about that I didn't even notice Prettier decided to hijack the markdown formatting. I added .vscode to the gitignore, I hope that's okay. The bind address can (and necessarily will in Docker) be different in Docker deployments. For example, the bind address to listen to incoming OAuth callbacks in a Docker container will be 0.0.0.0:PORT however the redirect address that must be sent to the OAuth provider (e.g. Microsoft or Google or whatever) needs to be the public address that eventually is routed to that bind address. Unfortunately, I noticed that various different remotes use different redirect URLs from the main oauthutil.go. Rather than update every single remote type to standardize what is used from oauthutil.go, it made more sense to allow the user to do a global override since the redirect URL will be managed by a reverse proxy anyway. |
|
Hi @ncw , just following up if everything looks right now |
What is the purpose of this change?
For Docker environments, need to bind to 0.0.0.0 instead of localhost
For rclone served by reverse proxy, should be able to override redirrect
Was the change discussed in an issue or in the forum before?
Fixes #7634
Checklist