Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building faiss main statically #2323

Conversation

robertmaynard
Copy link
Contributor

Cleans up a collection of anti-patterns in the raft CMake code while also enabling building faiss from latest main

@robertmaynard robertmaynard requested a review from a team as a code owner May 16, 2024 16:52
@robertmaynard robertmaynard added bug Something isn't working non-breaking Non-breaking change labels May 16, 2024
@robertmaynard robertmaynard force-pushed the bug/support_building_faiss_main_statically branch 2 times, most recently from 670f852 to a353891 Compare May 20, 2024 12:14
@robertmaynard robertmaynard force-pushed the bug/support_building_faiss_main_statically branch from a353891 to 6eb90bd Compare May 20, 2024 12:30
@robertmaynard robertmaynard force-pushed the bug/support_building_faiss_main_statically branch from 50551b4 to 0e5fae9 Compare May 20, 2024 18:54
@cjnolet
Copy link
Member

cjnolet commented May 21, 2024

cc @tfeher and @achirkin for awareness. This will probably need to be merged forward into your migration of raft-ann-bench to cuVS.

@cjnolet
Copy link
Member

cjnolet commented May 21, 2024

/merge

@rapids-bot rapids-bot bot merged commit 5a8224c into rapidsai:branch-24.06 May 21, 2024
69 checks passed
@robertmaynard robertmaynard deleted the bug/support_building_faiss_main_statically branch May 21, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CMake cpp non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants