Adds recover_fn to many routes. #5006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
force-pushed
the
recover_fn
branch
3 times, most recently
from
469acfb
to
8a398ea
Compare
There was a problem hiding this comment.
I think the following routes could have a recover_fn too:
es_compat_search_handler
es_compat_index_field_capabilities_handler
es_compat_index_search_handler
es_compat_index_count_handler
es_compat_index_multi_search_handler // also its comment uses the wrong route, should be _msearch
es_compat_scroll_handler
readiness_handler
| @@ -47,6 +48,7 @@ pub(crate) fn otlp_ingest_api_handlers( | |||
| .or(otlp_default_traces_handler(otlp_traces_service.clone())) | |||
| .or(otlp_logs_handler(otlp_logs_service)) | |||
| .or(otlp_ingest_traces_handler(otlp_traces_service)) | |||
| .recover(recover_fn) | |||
There was a problem hiding this comment.
not related to this PR: this group of routes isn't present in the openapi definition
There was a problem hiding this comment.
added routes to openapi..
If a route matches, we want to run its handler, and upon failure, the last thing we want is for another overlapping route to be executed as a fallback. To avoid this, we call recover on each individual routes that have no overlap with routes of lesser priority.
trinity-1686a
approved these changes
Jun 10, 2024
| @@ -29,7 +29,8 @@ struct EnvFilter { | |||
| filter: String, | |||
| } | |||
|
|
|||
| #[utoipa::path(get, tag = "Log level", path = "/log-level")] | |||
| /// Dynamically Quickwit's log level | |||
There was a problem hiding this comment.
Suggested change
| /// Dynamically Quickwit's log level | |
| /// Dynamically set Quickwit's log level |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a route matches, we want to run its handler, and upon failure, the last thing we want is for another overlapping route to be executed as a fallback.
To avoid this, we call recover on each individual routes that have no overlap with routes of lesser priority.