Fix extract_values invert parameter for multi-component values
#6057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6057 +/- ##
=======================================
Coverage 96.99% 96.99%
=======================================
Files 141 141
Lines 24640 24641 +1
=======================================
+ Hits 23899 23900 +1
Misses 741 741 |
|
@pyvista-bot preview |
tkoyama010
reviewed
May 13, 2024
tkoyama010
reviewed
May 13, 2024
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
invertparameter of theextract_valuesfilter (from #5963 and #6001) does not work as expected for multi-component values. This PR fixes this.This bug was discovered as part of #5968 , which uses this filter in some tests.