New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NetCDFCFReader
support Network Common Data Form
#6027
base: main
Are you sure you want to change the base?
Conversation
NetCDFReader
support Network Common Data FormNetCDFCFReader
support Network Common Data Form
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6027 +/- ##
========================================
Coverage 96.96% 96.97%
========================================
Files 141 141
Lines 24532 24655 +123
========================================
+ Hits 23788 23909 +121
- Misses 744 746 +2 |
@pyvista-bot preview |
@pyvista-bot preview |
@pyvista-bot preview |
@bjlittle I guess you are interested in this reader. |
@tkoyama010 Yup, sure am ... But it's not clear to me how you control deserializing the variables in the NetCDF file into a mesh. I'm guessing it's not truly generic and must conform to a specific format for the VTK reader. I'll hit the VTK docs and look at the example NetCDF file ... |
Pull request was converted to draft
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tkoyama010 This looks like a great addition 😄
Note that, you should probably update the supported file types and readers in the doc-string of get_reader for the ".nc"
supported files.
Also, as an aside, the example file that you load tos_O1_2001-2002.nc
has a time dimension with 24 time steps ... is it possible to control from the NetCDFCFReader
API which index in the time dimension will be loaded into the tos
variable on the resultant mesh?
Thanks! Resolved in 50489ca.
Good idea! I'm checking to see if we can use any |
@tkoyama010 Once you've resolved your conflicts, then we can bank this pull-request 👍 I wouldn't expect you to extend the API of the reader in this pull-request to control features of the NetCDF reader ... save that for another time. But I'd love to know whether you think this is easily possible and what it would involve. |
https://gitlab.kitware.com/vtk/vtk/-/blob/v9.3.0/IO/NetCDF/Testing/Python/NetCDFReader.py#L27 reader.SetVariableArrayStatus("tos",1) |
Overview
Add
NetCDFCFReader
support Network Common Data Form.Details