Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sigmoid_15 and sigmoid_20 opacity transfer functions #5944

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

user27182
Copy link
Contributor

Sometimes, more sigmoid is needed. This PR adds two new sigmoids for plotting volumes. sigmoid_15 is used by #5943. I found that for plotting high-intensity values only, e.g. showing only bones without any soft tissue, sigmoid_10 wasn't enough.

@pyvista-bot pyvista-bot added the enhancement Changes that enhance the library label Apr 19, 2024
Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Next time we need further value, let's be able to specify the sigmoid values dynamically.

@user27182
Copy link
Contributor Author

Thanks. Yes I agree dynamic would be better.

@tkoyama010 tkoyama010 enabled auto-merge (squash) April 19, 2024 00:42
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.89%. Comparing base (c297138) to head (fac3ba2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5944   +/-   ##
=======================================
  Coverage   96.89%   96.89%           
=======================================
  Files         139      139           
  Lines       24156    24156           
=======================================
  Hits        23405    23405           
  Misses        751      751           

@tkoyama010 tkoyama010 merged commit e0005ae into pyvista:main Apr 19, 2024
27 checks passed
@user27182 user27182 deleted the feat/more_sigmoid branch April 19, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Changes that enhance the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants