Check variable assignments that immediately return #5911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
tkoyama010
commented
Apr 12, 2024
|
@pyvista-bot LGTM |
pyvista-bot
previously approved these changes
Apr 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5911 +/- ##
==========================================
- Coverage 96.99% 96.99% -0.01%
==========================================
Files 141 141
Lines 24641 24624 -17
==========================================
- Hits 23900 23883 -17
Misses 741 741 |
|
@pyvista-bot LGTM |
pyvista-bot
previously approved these changes
May 5, 2024
tkoyama010
commented
May 15, 2024
tkoyama010
commented
May 15, 2024
tkoyama010
commented
May 15, 2024
tkoyama010
commented
May 15, 2024
|
@pyvista-bot LGTM |
pyvista-bot
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Checks for variable assignments that immediately precede a
returnof the assigned variable.Note
https://docs.astral.sh/ruff/rules/unnecessary-assign/
Caution
Based on this comment, ignore checks for changes in the composition of the if statement.