Dropping isort and move to lint.isort rule in ruff

[tkoyama010]

Overview

Dropping isort and moving to lint.isort rule in ruff.

Details

• See https://docs.astral.sh/ruff/rules/#isort-i.

[tkoyama010]

pre-commit.ci autofix

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.55%. Comparing base (e338c17) to head (c12bfc7).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5712   +/-   ##
=======================================
  Coverage   96.55%   96.55%           
=======================================
  Files         137      137           
  Lines       23395    23395           
=======================================
  Hits        22589    22589           
  Misses        806      806           

[user27182]

I'm not sure how much overlap this tool has with isort, but this seems worth considering :

https://github.com/asottile/reorder-python-imports

Its main goal is to reduce merge conflicts.

[user27182]

I'm not sure how much overlap this tool has with isort, but this seems worth considering :

https://github.com/asottile/reorder-python-imports

Its main goal is to reduce merge conflicts.

For context, I stumbled upon reorder-python-imports trying to look for a solution to #5621 (comment) . In this case, reorder-python-imports could be used to automatically add from future import __annotations__ to every file in the code base to support the type aliases for the docs. The config would be similar to this: https://github.com/asottile/pyupgrade/blob/df17dfa3911b81b4a27190b0eea5b1debc7ffa0a/.pre-commit-config.yaml#L18-L20

I plan on opening a new PR with reorder-python-imports to support this. And so if this works and the PR is accepted, then perhaps we may want to also use reorder-python-imports instead of isort. Just an idea though, I am not very familiar with these linting tools.

[tkoyama010]

Just an idea though, I am not very familiar with these linting tools.

No problem. We will review it.