Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump artifacts action version #5362

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

MatthewFlamm
Copy link
Contributor

@MatthewFlamm MatthewFlamm commented Dec 18, 2023

Overview

This PR bypasses dependabot update in an attempt to speed up documentation in the effort for #5352. v4 of upload-artifact and download-artifact are reported to be faster, up to 90% improvement in some cases.

Details

See https://github.com/actions/upload-artifact?tab=readme-ov-file#v4---whats-new

@github-actions github-actions bot added the maintenance Low-impact maintenance activity label Dec 18, 2023
@MatthewFlamm
Copy link
Contributor Author

A point of reference is that a recent run took longer than 31 minutes over two upload steps.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #5362 (49ece59) into main (11f4dea) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5362   +/-   ##
=======================================
  Coverage   96.38%   96.38%           
=======================================
  Files         134      134           
  Lines       22721    22721           
=======================================
  Hits        21900    21900           
  Misses        821      821           

@MatthewFlamm
Copy link
Contributor Author

This PR, the upload takes only 3.5 minutes. It turns out that our usage is near the 'worst case' reported for upload-artifact@v3

Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkoyama010
Copy link
Member

For no one to be surprised. Since the code owner was set up in #5312, this PR cannot be merged until the code owner approves it.

Copy link
Member

@banesullivan banesullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that accurate?! 30m down to ~3min?!!!

@banesullivan banesullivan merged commit 6d1583b into main Dec 18, 2023
26 checks passed
@banesullivan banesullivan deleted the maint/bump-artifacts-action branch December 18, 2023 22:07
@MatthewFlamm
Copy link
Contributor Author

Accurate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants