-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump artifacts action version #5362
Conversation
A point of reference is that a recent run took longer than 31 minutes over two upload steps. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5362 +/- ##
=======================================
Coverage 96.38% 96.38%
=======================================
Files 134 134
Lines 22721 22721
=======================================
Hits 21900 21900
Misses 821 821 |
This PR, the upload takes only 3.5 minutes. It turns out that our usage is near the 'worst case' reported for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
For no one to be surprised. Since the code owner was set up in #5312, this PR cannot be merged until the code owner approves it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that accurate?! 30m down to ~3min?!!!
Accurate! |
Overview
This PR bypasses dependabot update in an attempt to speed up documentation in the effort for #5352. v4 of
upload-artifact
anddownload-artifact
are reported to be faster, up to 90% improvement in some cases.Details
See https://github.com/actions/upload-artifact?tab=readme-ov-file#v4---whats-new