-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: [unknown-option-value] False negative after --disable=all #9491
Draft
fellhorn
wants to merge
7
commits into
pylint-dev:main
Choose a base branch
from
fellhorn:dennis/fix/all-messages
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+45
β5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Keck <26092524+fellhorn@users.noreply.github.com>
Signed-off-by: Dennis Keck <26092524+fellhorn@users.noreply.github.com>
for more information, see https://pre-commit.ci
This comment has been minimized.
This comment has been minimized.
jacobtylerwalls
changed the title
Fix: [unknown-option-value] False negative after --disable=al
Fix: [unknown-option-value] False negative after --disable=all
Mar 9, 2024
Pierre-Sassoulas
added
Work in progress
False Negative π¦
No message is emitted but something is wrong with the code
Waiting on author
Indicate that maintainers are waiting for a message of the author
and removed
Work in progress
labels
Mar 18, 2024
This comment has been minimized.
This comment has been minimized.
github-actions
bot
added
the
Needs take over ποΈ
Orignal implementer went away but the code could be salvaged.
label
May 14, 2024
I plan to take another look but lately had not really much capacity. If the issue is urgent though, please feel free to take over. |
Pierre-Sassoulas
removed
the
Needs take over ποΈ
Orignal implementer went away but the code could be salvaged.
label
May 14, 2024
Signed-off-by: Dennis Keck <26092524+fellhorn@users.noreply.github.com>
for more information, see https://pre-commit.ci
Signed-off-by: Dennis Keck <26092524+fellhorn@users.noreply.github.com>
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 3509270 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
False Negative π¦
No message is emitted but something is wrong with the code
Waiting on author
Indicate that maintainers are waiting for a message of the author
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #9403 by excluding a set of internal pylint messages from
--disable=all
.As this is my first PR to pylint I appreciate any comment on the solution. Especially in regards of the message codes and having to change an existing test.