Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mutelist): Handle exceptions before match #4024

Merged
merged 2 commits into from
May 20, 2024

Conversation

jfagoagas
Copy link
Member

Description

Handle a case when the exceptions where matching before the real mutelist match.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas requested review from a team as code owners May 17, 2024 14:15
@jfagoagas jfagoagas added the backport-v3 Pending to port to Prowler v3 branch label May 17, 2024
@jfagoagas jfagoagas self-assigned this May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.57%. Comparing base (53cfcff) to head (bc8b5b0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4024      +/-   ##
==========================================
- Coverage   86.65%   86.57%   -0.09%     
==========================================
  Files         777      777              
  Lines       24139    24140       +1     
==========================================
- Hits        20918    20898      -20     
- Misses       3221     3242      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@drewkerrigan drewkerrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed locally, thanks @jfagoagas! 🚢

@jfagoagas jfagoagas requested a review from pedrooot May 20, 2024 07:41
Copy link
Member

@pedrooot pedrooot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jfagoagas jfagoagas merged commit 73b3484 into master May 20, 2024
10 of 11 checks passed
@jfagoagas jfagoagas deleted the PRWLR-3715-investigate-mute-list-problem-in-prowler branch May 20, 2024 10:30
jfagoagas added a commit that referenced this pull request May 21, 2024
@jfagoagas jfagoagas removed the backport-v3 Pending to port to Prowler v3 branch label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants