-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warning for yubikey MFA for Windows #2566
Conversation
Signed-off-by: oppressor1761 <163018825+oppressor1761@users.noreply.github.com>
✅ Your preview is ready!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I don't think we need to explicitly say "consider your threat model" on the site though. We could just as well say it under every single recommendation. This is kind of implied...
Signed-off-by: oppressor1761 <163018825+oppressor1761@users.noreply.github.com>
Let me be more clearer: I donot think using Yubikey MFA to harden Windows local account should be recommended because this adds too much attack surface. Any 0-day in the app required could leave your account compromised. If you are concerned use a long password or remove local account login for Windows is the right move, not using Yubikey MFA. |
Tend to agree here. Might also be good to point out that windows hello does have support for security keys. |
Actually, I disagree with the premise that this could lead to account compromise in the first place. The app only adds a second factor in addition to the existing username+password security. In the unlikely event that the app fails, you should not be worse off than single-factor authentication. Windows Hello would replace a password I believe, which is not necessarily desirable behavior here. |
Signed-off-by: oppressor1761 <163018825+oppressor1761@users.noreply.github.com>
The app (Yubico Login for Windows) does not just add a factor. It replaces the whole login process for the local account. It's the app not Windows who verify both password and Yubikey. It is possible that exploits in the app lead to account compromise. It's not open source so we donot know how exactly it handles the password entered. best to not trust it in the login process. |
It adds a credential provider in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I double checked later and you're right. These changes LGTM now 👍
I'm not very familar with the PR process. Can anyonw tell me why this is still not merged? |
Signed-off-by: Daniel Gray <dngray@privacyguides.org> Co-Authored-By: oppressor1761 <163018825+oppressor1761@users.noreply.github.com>
Changes proposed in this PR:
Contribution terms (click to expand)
1) I am the sole author of this work. 2) I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project. 3) I have disclosed any relevant conflicts of interest in my post. 4) I agree to the Community Code of Conduct.