-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Major] Remove legacy color support #2607
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: be73387 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
src/color-modes/themes/dark.scss
Outdated
@include color-mode-theme(dark) { | ||
@include primer-colors-dark; | ||
} | ||
@import '@primer/primitives/dist/css/functional/themes/dark.css'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're gonna go with a major, I say we just completely remove the src/color-modes/
folder and use the primitives imports directly in dotcom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
This PR removes support for color themes. Going forward, Primer expects an explicit color theme import directly from
primer/primitives
.This is a breaking change and marked as such.