Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the suggestions of https://github.com/pridiltal/staplr/pull/53#i… #54

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

prdm0
Copy link
Contributor

@prdm0 prdm0 commented Sep 16, 2021

…ssuecomment-920510892.

@prdm0
Copy link
Contributor Author

prdm0 commented Sep 16, 2021

@pridiltal , I made the requested changes. It might be interesting for you to run pkgdown::build_site(). I did not run it so as not to make it difficult for you to check the changes suggested in #53 .

@prdm0
Copy link
Contributor Author

prdm0 commented Sep 23, 2021

Hi @pridiltal , I created a new logo suggestion and it includes the code for automatic logo generation that is in img.
see

@prdm0
Copy link
Contributor Author

prdm0 commented Sep 23, 2021

What this pull request does is:

1 - Implement the changes suggested in #53 ;
2 - Introduces a new hex sticker idea to the package. Also, in the img/logo directory you will find the code to generate the hex sticker automatically. This new directory has been added to the .Rbuildignore file.

@prdm0
Copy link
Contributor Author

prdm0 commented Sep 27, 2021

@pridiltal ,What this pull request does is:

1 - Implement the changes suggested in #53 ;
2 - Introduces a new hex sticker idea to the package. Also, in the img/logo directory you will find the code to generate the hex sticker automatically. This new directory has been added to the .Rbuildignore file;
3 - I put a more attractive theme on the package website matching the new logo proposal.

see

Best regards.

@prdm0
Copy link
Contributor Author

prdm0 commented Oct 21, 2021

Hi @pridiltal , any position on this pull request?

Best regards.

@pridiltal
Copy link
Owner

Thank you very much @prdm0 for this pull request!. staple_pages now enhances its capabilities. We can now add this to the package.

This new sticker looks great!! However, our already existing hex sticker for the package is already on the UseR hex wall https://twitter.com/pridiltal/status/1017225209688944641.

If possible could you please re-PR the staple_pages so that I can merge it directly without going for cherry pick

@prdm0
Copy link
Contributor Author

prdm0 commented Nov 23, 2021

Thank you very much @prdm0 for this pull request!. staple_pages now enhances its capabilities. We can now add this to the package.

This new sticker looks great!! However, our already existing hex sticker for the package is already on the UseR hex wall https://twitter.com/pridiltal/status/1017225209688944641.

If possible could you please re-PR the staple_pages so that I can merge it directly without going for cherry pick

Hi @pridiltal , thanks for your reply.

I think it's okay to have an old version of the sticker on UseR. Many packages like R Markdown and dplyr, for example, are changing their hex to more attractive versions. People will know that this is an evolution of the old hex.

But if you still don't want the change, that's fine. I will soon be able to submit a pull request with changes #53 .

Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants