Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add predefined quota on mailbox creation page #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

o-m-d
Copy link

@o-m-d o-m-d commented Feb 28, 2018

Filling Quota on mailbox creation page with value, defined in $CONF['mailbox_default_quota'].
It's useful for creating mailboxes with same quota.
When $CONF['mailbox_default_quota'] is empty (by default), mailbox creation page works as before - with empty Quota.

@cboltz
Copy link
Member

cboltz commented Feb 28, 2018

I agree that the quota field should be pre-filled (actually I wonder why it isn't and would call that a regression).

However, I don't agree with introducing a new config option for this - we already have enough config options ;-) and this isn't a case of "one size fits all [domains]". Maybe using the maximum allowed quota as default.would make sense? Typical users don't want less anyway ;-)

Hint: updateMaxquota() updates the description text with the maximum allowed quota, also updating the default there should be easy.

@o-m-d
Copy link
Author

o-m-d commented Mar 1, 2018

In some cases (eg on VPS or outdated hardware (sad but true)) mail admins don't want grant max quota to all mailboxes, and also want pre-filled some quota at every mailbox creation. In that cases I'm apply this patch manually.

I'm agree - one size to all domains not best solution. Maybe better add this as per-domain option, like a maxquota option? But it's requires more time.

@lelutin
Copy link

lelutin commented Mar 7, 2018

per-mailbox max quota would be a good value to pre-fill the field with imho. if I understand correctly there is already this value available, either as the default per-mailbox setting in $CONF['maxquota'], or set per-domain (probably in the database)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants