-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdcard structure refactor - sdcard part #1968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add an empty USR file with a description stating something like HERE WILL APPEAR YOUR DATA or something equal
Sure, but isn’t ensure_dir enough? I can add empty folders and git keep it tho. |
Done |
Once changed with all the suggestions, it will look clear and professional. |
Zxkmm sdcard refactor sdcard part
all requests fixed |
I'm closing this PR for now due to a lack of consensus on its benefits. We can revisit and reopen it if compelling reasons for the change come up. |
for easier review, i separated firmware change part and sdcard change part. This is sdcard change part
please don't merge as i need to merge myself.
test build(put world map yourself): https://github.com/zxkmm/mayhem-firmware/releases/tag/test_release