New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modules/battery): make rate positive if negative #3104

Open

classabbyamp wants to merge 2 commits into polybar:master from classabbyamp:negative-rate

classabbyamp commented Mar 24, 2024

What type of PR is this? (check all applicable)

Description

On the Lenovo X13s, the battery firmware returns a negative value for power_now, which is interpreted by the battery module as 0UL because it converts the string to unsigned long. This should be read as a long instead, as the kernel specifies that power_now is an int: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/include/linux/power_supply.h?h=v6.0.11#n99

Related Issues & Documents

Documentation (check all applicable)

This PR requires changes to the Wiki documentation (describe the changes)
This PR requires changes to the documentation inside the git repo (please add them to the PR).
Does not require documentation changes

classabbyamp added 2 commits

March 24, 2024 17:21


          fix(modules/battery): make rate positive if negative

fe6f909

on the Lenovo X13s, the battery firmware returns a negative value for
power_now, which is interpreted by the battery module as 0 because it
converts the string to unsigned long. This should be read as a long
instead, as the kernel specifies that power_now is an int:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/include/linux/power_supply.h?h=v6.0.11#n99


          src/modules/battery: clang-format

8ee6c2c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment