Adding options to display filesystem storage size output in a specific unit #3006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please merge this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This adds new formatting options to the filesystem which allow the user to force the displayed storage amount in to be in a specific unit, that does not change depending on amount available. For example the user could specify gb_free and the output would always be in Gigabytes, even when over 1000 or under 1.
While it is inconsistent with how storage device manufacturers market their products, I use the system that each unit is 1024 of the unit immediately smaller than it rather than 1000, to be consistent with existing code.
Related Issues & Documents
Documentation (check all applicable)
The new options would need adding to the wiki