Regex support for interfaces in network module #2853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2853 +/- ##
==========================================
- Coverage 13.17% 13.14% -0.03%
==========================================
Files 162 162
Lines 11509 11532 +23
==========================================
Hits 1516 1516
- Misses 9993 10016 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
patrick96
requested changes
Oct 29, 2022
* Added warning message * Fixed memory Leak * Running adapters get preference
patrick96
requested changes
Oct 31, 2022
| struct ifaddrs* ifaddrs; | ||
|
|
||
| if (regexpr.empty()) | ||
| return ""; |
| m_interface = net::find_interface_regex(m_interface); | ||
|
|
||
| if (!m_interface.empty()) | ||
| m_log.notice("%s: Matched regex %s with interface %s", name(), regexpr, m_interface); |
| m_interface = net::find_interface_regex(m_interface); | ||
|
|
||
| if (!m_interface.empty()) | ||
| m_log.notice("%s: Matched regex %s with interface %s", name(), regexpr, m_interface); | ||
|
|
||
| if (m_interface.empty()) { |
There was a problem hiding this comment.
If the regex doesn't match any interface, the module will shut down with the message Missing parameter "module/wireless.interface-type" because m_interface is empty again here.
If we tried to match using regex, we shouldn't try to use interface-type, so something like this:
if (!m_interface.empty()) {
// match regex
} else {
// find interface type
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
network module interface now supports regex
interface = wl.* will match any adapter named wlan0 wlan1 etc..
Related Issues & Documents
#2551
Documentation (check all applicable)