-
-
Notifications
You must be signed in to change notification settings - Fork 941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade #7805
base: v8
Are you sure you want to change the base?
Upgrade #7805
Conversation
💖 Thanks for opening this pull request! 💖 |
Don't reformat the code. |
…om other tsconfig files
We won't merge any refactoring to the v8 branch. That's for sure. Also, don't create a PR with so many changes. Formatting changes won't be merged. Other improvements that are not related to formatting changes can be discussed but in smaller PRs. |
…om every package into @pnpm/types, to reduce posibility of circular dependencies, improving types, getting rid of types-only packages.
@zkochan What is your main working branch? |
"main" is the main working branch. |
In reply to @JustFly1984 :
FYI, if your interested in understanding more about pull requests, and how to make them more readable for others, you can start here , or here. For best practices check this out and this as well Some suggestions:
Side note: Large format changes should be avoided. Code is formatted using linters/tools before they are committed and if a team ever decides they wish to change the rules and reformat, a big manual PR is probably not the best way. In my opinion, it would be best to update the lint/rules, and create a GitHub action that applies the formatting to the code and creates a pull request for all to review. That way, since the large diff is coming from the GitHub Action, team members can be certain no code changes unrelated to the formatting was "snuck in". |
Work in progress. Upgrading typescript@5.4.2, uodating dependencies, improving types, improving eslint