ddl: refine fatal log when upgrade failed because of tidb_enable_dist_task

[tangenta]

What problem does this PR solve?

Problem Summary:

• &*job is equivalent to job, it should use job.Clone() to create another instance.
• The log of upgrade failed is not clear.
• There is a typo in log "task scheduler exist".

What changed and how does it work?

Fix above three problems.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tangenta]

/ok-to-test

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.6049%. Comparing base (2e756fc) to head (9785fd5).
Report is 8 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #53392        +/-   ##
================================================
+ Coverage   72.5047%   74.6049%   +2.1001%     
================================================
  Files          1505       1505                
  Lines        429838     430753       +915     
================================================
+ Hits         311653     321363      +9710     
+ Misses        98860      89451      -9409     
- Partials      19325      19939       +614     

Flag	Coverage Δ
integration	49.1569% <50.0000%> (?)
unit	71.3401% <100.0000%> (-0.0529%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	53.9957% <ø> (ø)
parser	∅ <ø> (∅)
br	50.4130% <ø> (+9.0259%)	⬆️

[tangenta]

/retest

[D3Hunter]

rest lgtm

[D3Hunter]

does CtxVars matters here? it's not cloned

[tangenta]

CtxVars is only used by "reorg partition" and "rename tables", it is not used in "create tables".

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-05-21 08:04:00.959749397 +0000 UTC m=+2158794.716884963: ☑️ agreed by wjhuang2016.
• 2024-05-21 08:10:24.204735482 +0000 UTC m=+2159177.961871055: ☑️ agreed by D3Hunter.

[easonn7]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, easonn7, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/ddl/OWNERS [wjhuang2016]
• pkg/disttask/OWNERS [D3Hunter,wjhuang2016]
• pkg/session/OWNERS [easonn7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hawkingrei]

/retest

[tangenta]

/retest