fix(common): Move typing dependencies to peer #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
Something that could be interesting, is doing the same thing with form-render, but I am unsure if form-render is a real dependency |
|
The tests are passing with form-render as peer as well. Should I do additional checks? |
sebimarkgraf
changed the title
|
Hey @sebimarkgraf ! Sorry for the delayed response. |
|
Hi @hand-dot, any update on this MR, thank you. |
|
Hey @sebimarkgraf Sorry for the delayed review. Thank you for your contribution! |
|
Released as V4.0.2!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be a fix for #474 and the other related issues.
This ignores the type import of antd and casts it to any if antd is not installed.
Additionally, the antd dependency is downgraded to peer in common.
If ui is installed the direct dependency would lead to the correct typing being filled in.