[simulation] support simulating radio over IPv6 #10194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Report of OpenThread
|
bukepo
force-pushed
the
ipv6-local-host
branch
7 times, most recently
from
13ac684
to
9fb08a1
Compare
superwhd
reviewed
May 7, 2024
| inet_pton(AF_INET, UTILS_SOCKET_GROUP_ADDR, &mreq.imr_multiaddr); | ||
| for (struct ifaddrs *ifa = ifaddr; ifa != NULL; ifa = ifa->ifa_next) | ||
| { | ||
| if (ifa->ifa_addr == NULL || strcmp(ifa->ifa_name, aLocalHost) != 0) |
There was a problem hiding this comment.
ifa_name seems to be the interface name. https://man7.org/linux/man-pages/man3/getifaddrs.3.html
It's comparing the interface name with an IP address. Is this expected?
There was a problem hiding this comment.
aLocalHost can be an interface name.
There was a problem hiding this comment.
Can we rename the parameter aLocalHost and the global variable gLocalHost?
There was a problem hiding this comment.
I'm fine with renaming it in a separate PR.
bukepo
force-pushed
the
ipv6-local-host
branch
2 times, most recently
from
14c3669
to
777ebea
Compare
abtink
reviewed
May 10, 2024
This commit adds support to simulate Thread radio over IPv6. With this commit, a simulation will be simulated over either IPv6 or IPv4. If it's simulated on IPv6, it communicates with other simulation nodes in IPv6 group `ff02::116`. And if it's simulated on IPv4, it communicates with other simulation nodes in IPv4 group `224.0.0.116`. Note that simulating virtual time is not included in this commit.
All make sense! Fixed and uploaded. Thanks! |
lanyuwen
approved these changes
May 11, 2024
jwhui
approved these changes
May 13, 2024
bukepo
added a commit
to bukepo/openthread
that referenced
this pull request
May 15, 2024
This commit renames command line argument --local-host to --local-interface to reduce confusion as discussed in openthread#10194.
bukepo
added a commit
to bukepo/openthread
that referenced
this pull request
May 15, 2024
This commit renames command line argument --local-host to --local-interface to reduce confusion as discussed in openthread#10194. This commit also add help message for local interface.
bukepo
added a commit
to bukepo/openthread
that referenced
this pull request
May 15, 2024
This commit renames command line argument --local-host to --local-interface to reduce confusion as discussed in openthread#10194. This commit also add help message for local interface.
jwhui
pushed a commit
that referenced
this pull request
May 15, 2024
This commit renames command line argument --local-host to --local-interface to reduce confusion as discussed in #10194. This commit also add help message for local interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support to simulate Thread radio over IPv6.
With this commit, a simulation will be simulated over either IPv6 or IPv4. If it's simulated on IPv6, it communicates with other simulation nodes in IPv6 group
ff02::116. And if it's simulated on IPv4, it communicates with other simulation nodes in IPv4 group224.0.0.116.Note that simulating virtual time is not included in this commit.