[dnssd-server] implement DNS-SD discovery proxy functionality in core #10050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Report of OpenThread
|
abtink
force-pushed
the
disc-proxy-new
branch
3 times, most recently
from
c09d867
to
8bf2e5e
Compare
Cristib05
approved these changes
May 22, 2024
marius-preda
approved these changes
May 22, 2024
MarGasiorek
approved these changes
May 23, 2024
Vyrastas
requested changes
May 24, 2024
include/openthread/mdns.h
Outdated
Comment on lines
558
to
559
| * Refer to `otPlatDnssdAddressResolver` for documentation of member fields and `otMdnsStartIp6Resolver()` or | ||
| * `otMdnsStartIp4Resolver()` for how they are used. |
There was a problem hiding this comment.
otMdnsStartIp6Resolver --> otMdnsStartIp6AddressResolver
otMdnsStartIp4Resolver --> otMdnsStartIp4AddressResolver
There was a problem hiding this comment.
Fixed in new push. Thanks.
include/openthread/platform/dnssd.h
Outdated
Comment on lines
423
to
426
| typedef struct otPlatDnssdBrowseResult otPlatDnssdBrowseResult; | ||
| typedef struct otPlatDnssdSrvResult otPlatDnssdSrvResult; | ||
| typedef struct otPlatDnssdTxtResult otPlatDnssdTxtResult; | ||
| typedef struct otPlatDnssdAddressResult otPlatDnssdAddressResult; |
There was a problem hiding this comment.
Documentation that you have for these below don't come through in Doxygen when they are typedef'd up here:
I assume you've done this for a reason... can the documentation comment for each also be put up here?
There was a problem hiding this comment.
In the new push, I've re-arranged the type definitions and removed these.
These were intended as forward declarations so we can define the types in a more intuitive sequence. The challenge is that the Browser/Resolver types reference their corresponding Callback types, which in turn reference the Result type. We now define Result first, followed by Callback, and finally the Browser/Resolver structures.
There was a problem hiding this comment.
Thanks for rearranging, everything comes through now 👍
This commit implements a generic discovery proxy in the DNS-SD server. It uses a set of newly added `otPlatDnssd` platform DNS-SD(mDNS) APIs to start or stop browsers, SRV/TXT resolvers, and IPv6/IPv4 address resolvers. These APIs closely match the native OpenThread mDNS implementation. OpenThread DNS-SD's existing `QueryCallback` mechanism, enabling customized discovery proxy implementations, remains supported. This commit includes a comprehensive unit test. This test validates the discovery proxy's behavior, covering: standard use cases, request timeout, s hared resolver/browser usage for multiple queries with the same name, filtering of invalid addresses, and various edge cases.
Vyrastas
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements a generic discovery proxy in the DNS-SD server. It uses a set of newly added
otPlatDnssdplatform DNS-SD(mDNS) APIs to start or stop browsers, SRV/TXT resolvers, and IPv6/IPv4 address resolvers. These APIs closely match the native OpenThread mDNS implementation.OpenThread DNS-SD's existing
QueryCallbackmechanism, enabling customized discovery proxy implementations, remains supported.This commit includes a comprehensive unit test. This test validates the discovery proxy's behavior, covering: standard use cases, request timeout, s hared resolver/browser usage for multiple queries with the same name, filtering of invalid addresses, and various edge cases.