feat(core): KAS nano rewarp canAccess #825
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit involves the modification of the term 'policy' to 'Policy' in multiple places across the codebase. The changes affect variable names, error messages, comments, JSON tags, and more. It also introduces new methods to read Policy from the header. These changes ensure consistent usage of the term 'Policy' across the entire codebase.
The commit marks the method 'isPolicyBody' in 'sdk/nanotdf.go' as unused using the 'nolint' directive. This is likely to prevent linting tools from raising issues regarding this method, which might be left intentionally unused.
In the nanotdf.go file, a note has been added to the isPolicyBody function within the resourceLocator struct. This is to clarify that the function is a placeholder, used solely to satisfy the interface implementation requirements.
The 'nolint:unused' annotation on the 'isPolicyBody' method within the 'resourceLocator' structure has been removed. To circumvent misuse warning from linter, this method is now also implemented in 'nanotdf_test.go' file as a workaround allowing the function to be unused in the actual code but accessible in the test.
Removed redundancy by deleting the 'ErrInternal' constant and an unnecessary error handling block in the 'if header.Policy != nil' section. This simplifies error handling, making the code cleaner and easier to maintain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modification of the term 'policy' to 'Policy' in multiple places across the codebase. The changes affect variable names, error messages, comments, JSON tags, and more. It also introduces new methods to read Policy from the header. These changes ensure consistent usage of the term 'Policy' across the entire codebase.
resolves #807