-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): audit logging #774
Conversation
Can we abstract this to define enumerated events and the service? I'm concerned that without predefined events it's going to be hard to document and if we don't automatically scope to a service then there could be naming conflicts with the events. Like |
@strantalis informed me that there is already a plan in place that will address my concerns! |
…rm into feature/730-audit-package
🤖 I have created a release *beep* *boop* --- ## [0.4.3](service/v0.4.2...service/v0.4.3) (2024-05-22) ### Features * **authz:** Allow un-scoped GetEntitlements calls ([#833](#833)) ([9146947](9146947)) * **authz:** Handle jwts as entity chains in decision requests ([#759](#759)) ([65612e0](65612e0)) * **ci:** Add e2e roundtrip tests for different attribute combinations ([#790](#790)) ([1b0ec23](1b0ec23)) * **core:** Adds opentdf.hsm build constraint ([#830](#830)) ([e13e52a](e13e52a)) * **core:** audit logging ([#774](#774)) ([ea58b3c](ea58b3c)) ### Bug Fixes * **authz:** Populate fqn field in attribute values returned from GetAttributeValuesByFqns ([#816](#816)) ([0ac8390](0ac8390)) * **authz:** Typo in client secret config ([#835](#835)) ([7cad1f1](7cad1f1)) * bump internal versions ([#840](#840)) ([8f45f18](8f45f18)) * **core:** bump sdk deps to 0.2.3 ([#848](#848)) ([ca8b9f7](ca8b9f7)) * **policy:** fix policy fqn-reindex command schema suffix ([#818](#818)) ([aff9850](aff9850)), closes [#817](#817) * **policy:** GetAttributeValuesByFqns and MatchSubjectMappings should not return deactivated policy objects ([#813](#813)) ([41ca82d](41ca82d)), closes [#494](#494) * **policy:** make resource-mappings update patch instead of put in RESTful gateway ([#824](#824)) ([1878bb5](1878bb5)), closes [#313](#313) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.4.3](opentdf/platform@service/v0.4.2...service/v0.4.3) (2024-05-22) ### Features * **authz:** Allow un-scoped GetEntitlements calls ([#833](opentdf/platform#833)) ([9146947](opentdf/platform@9146947)) * **authz:** Handle jwts as entity chains in decision requests ([#759](opentdf/platform#759)) ([65612e0](opentdf/platform@65612e0)) * **ci:** Add e2e roundtrip tests for different attribute combinations ([#790](opentdf/platform#790)) ([1b0ec23](opentdf/platform@1b0ec23)) * **core:** Adds opentdf.hsm build constraint ([#830](opentdf/platform#830)) ([e13e52a](opentdf/platform@e13e52a)) * **core:** audit logging ([#774](opentdf/platform#774)) ([ea58b3c](opentdf/platform@ea58b3c)) ### Bug Fixes * **authz:** Populate fqn field in attribute values returned from GetAttributeValuesByFqns ([#816](opentdf/platform#816)) ([0ac8390](opentdf/platform@0ac8390)) * **authz:** Typo in client secret config ([#835](opentdf/platform#835)) ([7cad1f1](opentdf/platform@7cad1f1)) * bump internal versions ([#840](opentdf/platform#840)) ([8f45f18](opentdf/platform@8f45f18)) * **core:** bump sdk deps to 0.2.3 ([#848](opentdf/platform#848)) ([ca8b9f7](opentdf/platform@ca8b9f7)) * **policy:** fix policy fqn-reindex command schema suffix ([#818](opentdf/platform#818)) ([aff9850](opentdf/platform@aff9850)), closes [#817](opentdf/platform#817) * **policy:** GetAttributeValuesByFqns and MatchSubjectMappings should not return deactivated policy objects ([#813](opentdf/platform#813)) ([41ca82d](opentdf/platform@41ca82d)), closes [#494](opentdf/platform#494) * **policy:** make resource-mappings update patch instead of put in RESTful gateway ([#824](opentdf/platform#824)) ([1878bb5](opentdf/platform@1878bb5)), closes [#313](opentdf/platform#313) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.4.3](opentdf/platform@service/v0.4.2...service/v0.4.3) (2024-05-22) ### Features * **authz:** Allow un-scoped GetEntitlements calls ([#833](opentdf/platform#833)) ([9146947](opentdf/platform@9146947)) * **authz:** Handle jwts as entity chains in decision requests ([#759](opentdf/platform#759)) ([65612e0](opentdf/platform@65612e0)) * **ci:** Add e2e roundtrip tests for different attribute combinations ([#790](opentdf/platform#790)) ([1b0ec23](opentdf/platform@1b0ec23)) * **core:** Adds opentdf.hsm build constraint ([#830](opentdf/platform#830)) ([e13e52a](opentdf/platform@e13e52a)) * **core:** audit logging ([#774](opentdf/platform#774)) ([ea58b3c](opentdf/platform@ea58b3c)) ### Bug Fixes * **authz:** Populate fqn field in attribute values returned from GetAttributeValuesByFqns ([#816](opentdf/platform#816)) ([0ac8390](opentdf/platform@0ac8390)) * **authz:** Typo in client secret config ([#835](opentdf/platform#835)) ([7cad1f1](opentdf/platform@7cad1f1)) * bump internal versions ([#840](opentdf/platform#840)) ([8f45f18](opentdf/platform@8f45f18)) * **core:** bump sdk deps to 0.2.3 ([#848](opentdf/platform#848)) ([ca8b9f7](opentdf/platform@ca8b9f7)) * **policy:** fix policy fqn-reindex command schema suffix ([#818](opentdf/platform#818)) ([aff9850](opentdf/platform@aff9850)), closes [#817](opentdf/platform#817) * **policy:** GetAttributeValuesByFqns and MatchSubjectMappings should not return deactivated policy objects ([#813](opentdf/platform#813)) ([41ca82d](opentdf/platform@41ca82d)), closes [#494](opentdf/platform#494) * **policy:** make resource-mappings update patch instead of put in RESTful gateway ([#824](opentdf/platform#824)) ([1878bb5](opentdf/platform@1878bb5)), closes [#313](opentdf/platform#313) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
The main changes for the PR are in
logger.go
andaudit.go
where we add the new AUDIT log level and then add a specific method to the logger to log rewrap requests as an example. More detailed changes for other audit calls will be done as part of #719Examples of rewrap success log:
Parsed JSON string of audit log message: