fix(sdk): add example for token exchange #600
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkleene
force-pushed
the
normalize-token-exchange
branch
from
815dd5b
to
11b9c9c
Compare
mkleene
changed the title
dmihalcik-virtru
approved these changes
Apr 17, 2024
strantalis
reviewed
Apr 17, 2024
There was a problem hiding this comment.
@mkleene Did you mean to move these to the root of internal? They should live inside a oauth pkg if we are going ot move them.
There was a problem hiding this comment.
I can just make them unexported in the auth package I guess. Does that make sense?
There was a problem hiding this comment.
Then you won't be able to access them in the sdk package. Why wouldn't these make sense in the oauth package? Maybe we need some reorganization of pkgs if there isn't a good home for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also