Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.14] OCPBUGS-14373: Update kube vendor to fix HPA test flake #28812

Closed
wants to merge 2 commits into from

Conversation

jkyros
Copy link

@jkyros jkyros commented May 17, 2024

I fixed an HPA test flake over here in openshift/kubernetes#1958, but my understanding is the fix won't be reflected in the periodics until we have it in vendor here.

Reading the README here in openshift/origin it seemed like in order to make that happen, I was supposed to do:

$ hack/update-kube-vendor.sh release-4.14

So that's what I did. The deps do contain the fix I was looking for, so it looks like it worked, but it is entirely possible I am still an ignoramus and missing something 馃槃

Fixes: OCPBUGS-14373

Generated with: hack/update-kube-vendor.sh release-4.14

One of the HPA test cases was flaking, I fixed it in
openshift/kubernetes but we need to re-vendor here to pick up the fix.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 17, 2024
@openshift-ci-robot
Copy link

@jkyros: This pull request references Jira Issue OCPBUGS-14373, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
  • expected Jira Issue OCPBUGS-14373 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

I fixed an HPA test flake over here in openshift/kubernetes#1958, but my understanding is the fix won't be reflected in the periodics until we have it in vendor here.

Reading the README here in openshift/origin it seemed like in order to make that happen, I was supposed to do:

$ hack/update-kube-vendor.sh release-4.14

So that's what I did. The deps do contain the fix I was looking for, so it looks like it worked, but it is entirely possible I am still an ignoramus and missing something 馃槃

Fixes: OCPBUGS-14373

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 17, 2024
@openshift-ci openshift-ci bot requested review from bparees and stlaz May 17, 2024 20:31
@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label May 17, 2024
@openshift-ci openshift-ci bot added the e2e-images-update Related to images used by e2e tests label May 17, 2024
Copy link
Contributor

openshift-ci bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jkyros
Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented May 18, 2024

@jkyros: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-builds 98aaa59 link true /test e2e-gcp-ovn-builds
ci/prow/e2e-aws-ovn-fips 98aaa59 link true /test e2e-aws-ovn-fips
ci/prow/e2e-agnostic-ovn-cmd 98aaa59 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-ovn-serial 98aaa59 link true /test e2e-aws-ovn-serial
ci/prow/e2e-metal-ipi-ovn-ipv6 98aaa59 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-gcp-ovn 98aaa59 link true /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-single-node 98aaa59 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-single-node-upgrade 98aaa59 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-cgroupsv2 98aaa59 link false /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-gcp-ovn-upgrade 98aaa59 link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-openstack-ovn 98aaa59 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-etcd-recovery 98aaa59 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-metal-ipi-sdn 98aaa59 link false /test e2e-metal-ipi-sdn
ci/prow/e2e-aws-ovn-single-node-serial 98aaa59 link false /test e2e-aws-ovn-single-node-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jkyros
Copy link
Author

jkyros commented May 20, 2024

So:

  • hack/update-generated.sh changed registry.k8s.io/e2e-test-images/agnhost:2.43 to registry.k8s.io/e2e-test-images/agnhost:2.47, but
  • the tests are crying that registry.k8s.io/e2e-test-images/agnhost:2.43 isn't mirrored?

I would have expected it to complain about registry.k8s.io/e2e-test-images/agnhost:2.47 instead? Since that's the "new one"?

 {  Cluster accessed images that were not mirrored to the testing repository or already part of the cluster, see test/extended/util/image/README.md in the openshift/origin repo:

registry.k8s.io/e2e-test-images/agnhost:2.43 from pods:
  ns/e2e-test-cli-idling-8xn8z pod/idling-echo-1-6ttw9 node/ip-10-0-71-38.ec2.internal
  ns/e2e-test-cli-idling-8xn8z pod/idling-echo-1-g6s7k node/ip-10-0-13-168.ec2.internal
  ns/e2e-test-cli-idling-8xn8z pod/idling-echo-1-ggvzj node/ip-10-0-71-38.ec2.internal
  ns/e2e-test-cli-idling-8xn8z pod/idling-echo-1-lcfdp node/ip-10-0-37-59.ec2.internal
  ns/e2e-test-cli-idling-f7k5h pod/idling-echo-1-6dd47 node/ip-10-0-13-168.ec2.internal
  ns/e2e-test-cli-idling-f7k5h pod/idling-echo-1-6qvsh node/ip-10-0-13-168.ec2.internal
  ns/e2e-test-cli-idling-f7k5h pod/idling-echo-1-vggrg node/ip-10-0-71-38.ec2.internal
  ns/e2e-test-cli-idling-f7k5h pod/idling-echo-1-wgh8z node/ip-10-0-71-38.ec2.internal
}

I'm also apparently faling [sig-network][Feature:Router][apigroup:image.openshift.io] The HAProxy router should serve a route that points to two services and respect weights [Skipped:Disconnected] [Suite:openshift/conformance/parallel] on all of these too.

@jkyros
Copy link
Author

jkyros commented May 20, 2024

Looks like #28806 just did what I was trying to do, so I'm closing this. Thanks Maciej!

@jkyros jkyros closed this May 20, 2024
@openshift-ci-robot
Copy link

@jkyros: This pull request references Jira Issue OCPBUGS-14373. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

I fixed an HPA test flake over here in openshift/kubernetes#1958, but my understanding is the fix won't be reflected in the periodics until we have it in vendor here.

Reading the README here in openshift/origin it seemed like in order to make that happen, I was supposed to do:

$ hack/update-kube-vendor.sh release-4.14

So that's what I did. The deps do contain the fix I was looking for, so it looks like it worked, but it is entirely possible I am still an ignoramus and missing something 馃槃

Fixes: OCPBUGS-14373

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-images-update Related to images used by e2e tests jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants