Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress ollama_llama_server.exe blank command window popup #4287

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ashokgelal
Copy link

No description provided.

@jmorganca
Copy link
Member

I can't seem to reproduce this – how did you trigger it (do you have a screenshot etc?)

@jmorganca
Copy link
Member

Also: thanks for the PR!

@ashokgelal
Copy link
Author

It's kind of hard to repro but it's definitely reproducible. I'm working on an app that in a way embeds Ollama (downloads Ollama and runs serve in the "background" by spawning a process). The blank window pops up every time you interact with any model. More annoyingly, even if you minimize it, it randomly brings it to the foreground.

Also: thanks for the PR!

Actually, thank you for Ollama. Took me a couple of days to actually nail this down but I had fun learning the code base and hopefully will be able to contribute more in the future.

PS: I built Ollama locally and used the new exe and verified that this PR fixes it. Also, it doesn't seem to impact any of the current behavior.

image

@ashokgelal
Copy link
Author

@jmorganca any thoughts about this? Please Let me know if you need anything else from my side.

@ashokgelal
Copy link
Author

After some further testing, I found out that just the cmd.SysProcAttr = &syscall.SysProcAttr{CreationFlags: 0x08000000}, solves this issue and don't need to use cmd_path (I was trying to mimic

cmd_path := "c:\\Windows\\system32\\cmd.exe"
).

@jmorganca Should I create another PR and close this or just update this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants