Add information on model tagging to import.md.
#4109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add information on model tagging.
Clean up grammar and duplicate words.
thinkverse
commented
May 2, 2024
| If your model has different versions you can optionally tag them, without a tag, it will be `latest`: | ||
|
|
||
| ``` | ||
| ollama push <your username>/example[:tag] |
There was a problem hiding this comment.
Is this an OK example? It's based on Docker's push reference. Alternatively, the brackets can be removed.
Suggested change
| ollama push <your username>/example[:tag] | |
| ollama push <your username>/example:tag |
bsdnet
reviewed
May 3, 2024
docs/import.md
Outdated
| @@ -144,6 +144,16 @@ ollama push <your username>/example | |||
|
|
|||
| After publishing, your model will be available at `https://ollama.com/<your username>/example`. | |||
|
|
|||
| ### Tagging models | |||
|
|
|||
| If your model has different versions you can optionally tag them, without a tag it will be `latest`: | |||
There was a problem hiding this comment.
latest is a mutable tag, and not good practice. We should advocate tagging explicitly, not using latest if possible.
Modern container repositories does not support mutable tag because of security.
There was a problem hiding this comment.
I agree it would probably be better to remove the optionally part. Given latest is mutable it will be overwritten if you don't specify a tag. I will see if I can't come up with some better wording to get that across. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a section to the import documentation on model tagging and cleaned up the quantization reference section a smidge.