Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects documentation for the "stop" option parameter in modeldile.md #2922

Closed
wants to merge 2 commits into from

Conversation

dezoito
Copy link

@dezoito dezoito commented Mar 4, 2024

This PR corrects the type for the "stop" option documented in modelfile.md ("stop" should be an array of string):

As per

Stop []string `json:"stop,omitempty"`
:

// Options specfied in GenerateRequest, if you add a new option here add it to the API docs also
type Options struct {
	Runner

	// Predict options used at runtime
	NumKeep          int      `json:"num_keep,omitempty"`
	Seed             int      `json:"seed,omitempty"`
	...
	Stop             []string `json:"stop,omitempty"`
}

@dezoito dezoito changed the title Fix/docs Corrects documentation for the "stop" option parameter in modeldile.md Mar 4, 2024
@jmorganca
Copy link
Member

Hi there, thanks so much for the PR! While stop technically is an array it might be easier for the documentation to show that it can be provided in the Modelfile as individual strings, e.g.

PARAMETER stop <end>

Also, we should totally add Ollama Grid Search to the README.md! Would it be possible to open a PR for that?

@jmorganca jmorganca closed this May 9, 2024
@dezoito
Copy link
Author

dezoito commented May 9, 2024

@jmorganca, got it.

Also, we should totally add Ollama Grid Search to the README.md! Would it be possible to open a PR for that?

Sure!

PR submitted #4301

Thank you!

@dezoito dezoito deleted the fix/docs branch May 9, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants